Script to deploy linux wheel to S3 on release. #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oxtopus Please review. I've tested the deploy script locally, but will have to push a release to test in Travis-CI. |
| @@ -32,11 +34,12 @@ sudo pip install twine || exit | |||
| echo "Creating distribution files..." | |||
| # This release build creates the source distribution. All other release builds | |||
| # should not. | |||
| python setup.py sdist bdist || exit | |||
| python setup.py sdist bdist bdist_wheel || exit | |||
There was a problem hiding this comment.
Why use twine below in lieu of python setup.py sdist bdist bdist_wheel upload ?
There was a problem hiding this comment.
Following the recommendation of the official Python Packaging Guide.
(Recommended): Use twine
twine upload dist/*The biggest reason to use twine is that python setup.py upload (option # 2 below) uploads files over plaintext. This means anytime you use it you expose your username and password to a MITM attack. Twine uses only verified TLS to upload to PyPI protecting your credentials from theft.
|
👍 |
rhyolight
added a commit
that referenced
this pull request
Jan 9, 2015
Script to deploy linux wheel to S3 on release.
mihail911
pushed a commit
to mihail911/nupic
that referenced
this pull request
Aug 5, 2015
Script to deploy linux wheel to S3 on release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1744.